Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5360] Type annotations for BaseSensorOperator #5966

Merged

Conversation

TobKed
Copy link
Contributor

@TobKed TobKed commented Aug 30, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5360
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@TobKed TobKed force-pushed the pyhints-for-base-sensor-operator branch from ce7ff1b to 7c0ca72 Compare August 30, 2019 14:38
@TobKed TobKed changed the title [AIRIRFLOW-5360] Type annotations for BaseSensorOperator [AIRFLOW-5360] Type annotations for BaseSensorOperator Aug 30, 2019
@TobKed TobKed changed the title [AIRFLOW-5360] Type annotations for BaseSensorOperator [WIP][AIRFLOW-5360] Type annotations for BaseSensorOperator Aug 31, 2019
@TobKed TobKed changed the title [WIP][AIRFLOW-5360] Type annotations for BaseSensorOperator [AIRFLOW-5360] Type annotations for BaseSensorOperator Aug 31, 2019
@TobKed
Copy link
Contributor Author

TobKed commented Sep 2, 2019

cc @mik-laj @potiuk

@Fokko Fokko merged commit f46b54a into apache:master Sep 3, 2019
@TobKed TobKed deleted the pyhints-for-base-sensor-operator branch September 19, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants